Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for obvious incorrect data values in optional debug run #267

Open
yousefmoazzam opened this issue Mar 25, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@yousefmoazzam
Copy link
Collaborator

In attempts to run benchmarks on real data (20GB+) using this pipeline, instances of the paganin_filter_tomopy from httomolibgpu producing NaN values have been encountered.

In this particular case, the NaN values were not initially detected to have originated from the paganin filter method due to no runtime error occurring. The runtime error encountered in rescale_to_int (occurring two sections later than the section the paganin filter was in), and it took some time to work from the runtime error in rescale_to_int all the way back to its origin in the paganin filter in the first section.

To mitigate issues like this, it may be useful to have some kind of debug checks being performed at runtime (perhaps enabled by a --debug flag in the CLI?) that check things that are obviously wrong with data, such as:

  • output of block processing being all zeros
  • output of block processing being all NaN values
  • presence of NaN values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant