Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I24 ssx: get the beam centre from file #42

Closed
noemifrisina opened this issue Sep 13, 2023 · 1 comment · Fixed by #55
Closed

I24 ssx: get the beam centre from file #42

noemifrisina opened this issue Sep 13, 2023 · 1 comment · Fixed by #55
Assignees
@noemifrisina
Labels
I24 serial Issues relating to ssx on I24

Comments

@noemifrisina
Copy link
Contributor

When setting the fiducials (i24ssx_moveonclick.py), beam X/Y hardcoded and needs to be changed every time. Instead of this, we should be grabbing the values from GDA so they are current
@DominicOram DominicOram mentioned this issue Sep 14, 2023
Closed
@DominicOram
Copy link
Contributor

We should use OAVParameters for this (https://github.com/DiamondLightSource/dodal/blob/7058d115fccc599ad36274f5bc313c9765376d74/src/dodal/devices/oav/oav_parameters.py#L19)

@noemifrisina noemifrisina mentioned this issue Sep 13, 2023
Open
@noemifrisina noemifrisina added the I24 serial Issues relating to ssx on I24 label Sep 15, 2023
This was referenced Oct 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noemifrisina noemifrisina

Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I24: get the beam centre from the DiamondLightSource/mx-bluesky
2 participants
@DominicOram @noemifrisina