-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put waiting logic on device side #381
Labels
Comments
Same is true for |
DominicOram
changed the title
Put scan invalid logic on device side
Put waiting logic on device side
May 17, 2023
Arm/Disarm done in DiamondLightSource/hyperion#749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DiamondLightSource/hyperion#248 added some logic for waiting to check that our scan was valid. However, we shouldn't be doing this polling waiting in the plan, instead we should refactor the device so that we can use
bps.wait
in the plan. We have copied all over the code now, and they should all be updated to a nicer pattern:wait_for_det_to_finish_moving
Note
The text was updated successfully, but these errors were encountered: