Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put waiting logic on device side #381

Open
DominicOram opened this issue Dec 9, 2022 · 2 comments
Open

Put waiting logic on device side #381

DominicOram opened this issue Dec 9, 2022 · 2 comments
Labels

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Dec 9, 2022

DiamondLightSource/hyperion#248 added some logic for waiting to check that our scan was valid. However, we shouldn't be doing this polling waiting in the plan, instead we should refactor the device so that we can use bps.wait in the plan. We have copied all over the code now, and they should all be updated to a nicer pattern:

  • wait_for_det_to_finish_moving

Note

@DominicOram
Copy link
Contributor Author

Same is true for wait_for_det_to_finish_moving

@DominicOram DominicOram changed the title Put scan invalid logic on device side Put waiting logic on device side May 17, 2023
@DominicOram DominicOram added the good first issue Good for newcomers label May 17, 2023
@DominicOram
Copy link
Contributor Author

DominicOram commented Jun 16, 2023

Arm/Disarm done in DiamondLightSource/hyperion#749

@DominicOram DominicOram transferred this issue from DiamondLightSource/hyperion Sep 2, 2024
@olliesilvester olliesilvester removed the good first issue Good for newcomers label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants