-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for command SUMVAL
#24
Comments
Could we compute the summation at insert/ dumping time to ensure that results of this "SUMVAL" is quick to fetch? |
@golu360 Yes. That would be an enhancement. The reason I was thinking of having a |
Then similar to summation, could we also similar stuff like "AVGVAL" for average of all integer values? |
To summarize my solution,
|
@arpitbbhayani I would like to work on this! :D |
@golu360 Let's do it on runtime; instead of keeping it pre-computed. Also, check for the encoding because not all values will be integers. The reason we are doing this is to support runtime piped operations in the future. If you are okay with this let me know, I will assign it to you. |
@arpitbbhayani Sounds even simpler then. Will do it on run-time. |
@arpitbbhayani do we also need to submit a design doc for this? |
@arpitbbhayani is this issue still open? |
Yes. Are you interested in picking this up? |
Yup. Up to pick it! @arpitbbhayani |
Assigned it to you. Thanks for picking it up. |
@arpitbbhayani are we only expecting integers or are we also expecting floats here? |
Depends on the encoding. Right now we do not support float. Go through the code and use types and encodings we explicitly maintain. Please understand the flow before you code. |
@arpitbbhayani @JyotinderSingh Code base has change since this was assigned. I was also thinking if we could find the sum of all values given a string pattern as well.
Which returns the sum of all transaction amounts. If no key or pattern is passed, we return the sum of all the numeric values. What are your thoughts on this? |
@golu360 I think we should skip this one. SUMVAL is not in our roadmap any more. we are chasing reactivity and this command does not fit into the scheme. Apologies for this. I should have closed this issue long time back. You can find other issue to pick. thank you so much :) |
Is your feature request related to a problem? Please describe.
There are no KV databases that support values-based aggregations. Doing a summation of integer values in the KV store would help us address a bunch of real-world use-cases
Describe the solution you'd like
Introduce a command
SUMVAL
that does a summation of all the values and returns the result.The text was updated successfully, but these errors were encountered: