Fix/duplicate vtt cues #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.9.0 to 4.9.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.9.1/packages/eslint-plugin) Signed-off-by: dependabot[bot] <support@github.com>
…arn/typescript-eslint/eslint-plugin-4.9.1 [skip ci]: Bump @typescript-eslint/eslint-plugin from 4.9.0 to 4.9.1
Bumps [husky](https://github.com/typicode/husky) from 4.3.0 to 4.3.5. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v4.3.0...v4.3.5) Signed-off-by: dependabot[bot] <support@github.com>
…arn/husky-4.3.5 [skip ci]: Bump husky from 4.3.0 to 4.3.5
Always parse ID3 tags if type is present on the ID3 Frame
* patch/v0.14.x: Merge pull request video-dev#3284 from video-dev/update-id3-parsing
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 5.4.0 to 5.4.1. - [Release notes](https://github.com/survivejs/webpack-merge/releases) - [Changelog](https://github.com/survivejs/webpack-merge/blob/develop/CHANGELOG.md) - [Commits](survivejs/webpack-merge@v5.4.0...v5.4.1) Signed-off-by: dependabot[bot] <support@github.com>
…arn/webpack-merge-5.4.1 [skip ci]: Bump webpack-merge from 5.4.0 to 5.4.1
Bumps [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) from 8.0.4 to 8.2.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha) Signed-off-by: dependabot[bot] <support@github.com>
…arn/types/mocha-8.2.0 [skip ci]: Bump @types/mocha from 8.0.4 to 8.2.0
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.69.1 to 2.69.3. - [Release notes](https://github.com/netlify/cli/releases) - [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md) - [Commits](netlify/cli@v2.69.1...v2.69.3) Signed-off-by: dependabot[bot] <support@github.com>
…arn/netlify-cli-2.69.3 [skip ci]: Bump netlify-cli from 2.69.1 to 2.69.3
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.9.0 to 4.9.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.9.1/packages/parser) Signed-off-by: dependabot[bot] <support@github.com>
…arn/typescript-eslint/parser-4.9.1 [skip ci]: Bump @typescript-eslint/parser from 4.9.0 to 4.9.1
Bumps [@babel/register](https://github.com/babel/babel/tree/HEAD/packages/babel-register) from 7.12.1 to 7.12.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.10/packages/babel-register) Signed-off-by: dependabot[bot] <support@github.com>
…arn/babel/register-7.12.10 [skip ci]: Bump @babel/register from 7.12.1 to 7.12.10
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.69.3 to 2.69.4. - [Release notes](https://github.com/netlify/cli/releases) - [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md) - [Commits](netlify/cli@v2.69.3...v2.69.4) Signed-off-by: dependabot[bot] <support@github.com>
…arn/netlify-cli-2.69.4 [skip ci]: Bump netlify-cli from 2.69.3 to 2.69.4
update sauce-connect action to a version with retries
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 5.4.1 to 5.5.0. - [Release notes](https://github.com/survivejs/webpack-merge/releases) - [Changelog](https://github.com/survivejs/webpack-merge/blob/develop/CHANGELOG.md) - [Commits](survivejs/webpack-merge@v5.4.1...v5.5.0) Signed-off-by: dependabot[bot] <support@github.com>
…arn/webpack-merge-5.5.0 [skip ci]: Bump webpack-merge from 5.4.1 to 5.5.0
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.7 to 7.12.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.10/packages/babel-preset-env) Signed-off-by: dependabot[bot] <support@github.com>
…arn/babel/preset-env-7.12.10 [skip ci]: Bump @babel/preset-env from 7.12.7 to 7.12.10
…arn/sinon-9.2.2 [skip ci]: Bump sinon from 9.2.1 to 9.2.2
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot[bot] <support@github.com>
…arn/typescript-4.1.3 [skip ci]: Bump typescript from 4.1.2 to 4.1.3
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 86.0.0 to 87.0.4. - [Release notes](https://github.com/giggio/node-chromedriver/releases) - [Commits](https://github.com/giggio/node-chromedriver/commits) Signed-off-by: dependabot[bot] <support@github.com>
…arn/chromedriver-87.0.4 [skip ci]: Bump chromedriver from 86.0.0 to 87.0.4
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.9.1 to 4.10.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.10.0/packages/eslint-plugin) Signed-off-by: dependabot[bot] <support@github.com>
…arn/typescript-eslint/eslint-plugin-4.10.0 [skip ci]: Bump @typescript-eslint/eslint-plugin from 4.9.1 to 4.10.0
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.9.1 to 4.10.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.10.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com>
…arn/typescript-eslint/parser-4.10.0 [skip ci]: Bump @typescript-eslint/parser from 4.9.1 to 4.10.0
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.69.8 to 2.69.9. - [Release notes](https://github.com/netlify/cli/releases) - [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md) - [Commits](netlify/cli@v2.69.8...v2.69.9) Signed-off-by: dependabot[bot] <support@github.com>
…arn/netlify-cli-2.69.9 [skip ci]: Bump netlify-cli from 2.69.8 to 2.69.9
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.69.9 to 2.69.10. - [Release notes](https://github.com/netlify/cli/releases) - [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md) - [Commits](netlify/cli@v2.69.9...v2.69.10) Signed-off-by: dependabot[bot] <support@github.com>
…arn/netlify-cli-2.69.10 [skip ci]: Bump netlify-cli from 2.69.9 to 2.69.10
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 5.7.0 to 5.7.2. - [Release notes](https://github.com/survivejs/webpack-merge/releases) - [Changelog](https://github.com/survivejs/webpack-merge/blob/develop/CHANGELOG.md) - [Commits](survivejs/webpack-merge@v5.7.0...v5.7.2) Signed-off-by: dependabot[bot] <support@github.com>
…arn/webpack-merge-5.7.2 [skip ci]: Bump webpack-merge from 5.7.0 to 5.7.2
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.10 to 7.12.11. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.11/packages/babel-preset-env) Signed-off-by: dependabot[bot] <support@github.com>
…arn/babel/preset-env-7.12.11 [skip ci]: Bump @babel/preset-env from 7.12.10 to 7.12.11
such as on a fork
do not run automerge action if secret not available
Bumps [eslint](https://github.com/eslint/eslint) from 7.15.0 to 7.16.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.15.0...v7.16.0) Signed-off-by: dependabot[bot] <support@github.com>
…arn/eslint-7.16.0 [skip ci]: Bump eslint from 7.15.0 to 7.16.0
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.69.10 to 2.69.11. - [Release notes](https://github.com/netlify/cli/releases) - [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md) - [Commits](netlify/cli@v2.69.10...v2.69.11) Signed-off-by: dependabot[bot] <support@github.com>
…arn/netlify-cli-2.69.11 [skip ci]: Bump netlify-cli from 2.69.10 to 2.69.11
Reuse the hash function when creating the 608/708 VTTCues to assign them a unique id. Extract the webvtt-parser callback function that adds text track cues and reuse it for adding the 608/708 cues. Wasn't sure what is the best way to use the hash function - if to leave it in webvtt-aprser and expose or extract it to a seperate vtt utils function and import in both parser and cues modules. I ended up exposing it from webvtt-parser and adding the id in timeline-controller, but it makes more sense to keep the logic near where VTTCue is created. Let me know if you want to change this in anyway- open for comments. In addition, added text field to VTTCue interface.
…to fix/duplicate-vtt-cues
grabofus
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A combination of video-dev#3321 and this fix for v1. The former had to be supplemented with the latter as it wasn't quite working on its own.
## To do