-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import meta/tags using provided URL while download new archives by built-in downloader #601
Comments
That should indeed be the expected behavior -- I'm pretty sure the metadata plugins will match on URL as long as said URL is correct. There's been some fixes in nightlies recently (#593) to be more permissive on |
I looked into the Meta plugin, found
these codes seems to extract the "source" tag from existing tags. However, when I download a new comic using |
Another question, may be off-topic. Is there any difference between |
The MEMS plugin is only useful if you have the matching userscript on your browser: The base EH plugin does everything you'd need as a regular user. As for downloading through add archives, it calls on the DL system all the same so you should be getting source tags. |
It is confirmed that if I download other books without using the plugins: source tag is not added. I think it is not what I expected, correct? Related code found here, still investigating. LANraragi/lib/LANraragi/Utils/Minion.pm Lines 219 to 223 in 6c1b241
|
Found the source of the problem: |
I'm not sure if it is because of this: LANraragi/lib/LANraragi/Utils/Database.pm Lines 60 to 70 in 543609b
Using hset causes redis to overwrite existing tags |
I found in this commit, DateAdded plugin was fully deprecated. However, considering that DateAdded plugin still exists, and the actual thing it do is a tag plugin, can I revert this commit, and remove "Add Timestamp Tag" from config pannel, and move "Use "Last modified" Time" to plugin's config? In a word, reuse the DateAdded plugin? |
Thanks for the detailed investigation: I don't plan on removing the built-in timestamp feature since third-party clients have come to rely on I've pushed out a simple fix so that you can have |
When want to download an archive from the Internet,
I use the Adding Archives to the Library function combined with Metadata Plugins, hoping to automatically add meta.
Take E-Hentai plugin for example, It seems that if I turn on "Run Automatically" and give "URL(s) to download".
It will always match metadata using TITLE instead of URL I provided in the downloader.
This can result in mismatch when the title contains Unicode characters, or multiple gallary shares the similar title.
My current solution is to disable "Run Automatically" option and Use "Click here to edit metadata." function to manually paste the "E-H Gallery URL (Will attach tags matching this exact gallery to your archive)".
Is it possible to just let "Mayriad's EH Master Script" to retrieve the URL I provided in the downloader, and use that information to search for metadata?
The text was updated successfully, but these errors were encountered: