This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Delete trigger bug fix #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Unable to delete forum when there are no entries in it.
Problem: Before deleting the forum, the trigger checks for the e_deleted_by col in the corresponding forum entries to ensure that the user giving the delete command has permission to do it. However, this becomes a problem for forum with no entries, as there isn't an e_deleted_by col to check. Therefore, forum deletion fails.
Fix: Add if condition to the trigger func for cases where there are no entries in the forum --> delete the forum.