Fix bash parameter escaping as passed to docker. #89

manthey · 2020-03-20T13:26:45Z

In order to preserve whitespace in parameters, this uses some arcane bash operations. There is probably a better way to do it, but this works in various tests.

In order to preserve whitespace in parameters, this uses some arcane bash operations. There is probably a better way to do it, but this appears to work in various tests.

BryonLewis · 2020-03-20T13:51:46Z

pulled and tested:
./build.sh --watch
./build.sh --watch-plugin histomicsui
./build.sh --watch-plugin slicer_cli_web
./test.sh -e lintclient
./test.sh -e py37
./test.sh -e py37 -- -k configViewSpec
Seemed to work properly for all of the above

BryonLewis

Testing commonly used commands was successful.

Fix bash parameter escaping as passed to docker.

9369606

In order to preserve whitespace in parameters, this uses some arcane bash operations. There is probably a better way to do it, but this appears to work in various tests.

manthey requested a review from BryonLewis March 20, 2020 13:26

BryonLewis approved these changes Mar 20, 2020

View reviewed changes

manthey merged commit 3565f5a into master Mar 20, 2020

manthey deleted the fix-parameter-escaping branch March 20, 2020 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bash parameter escaping as passed to docker. #89

Fix bash parameter escaping as passed to docker. #89

manthey commented Mar 20, 2020

BryonLewis commented Mar 20, 2020

BryonLewis left a comment

Fix bash parameter escaping as passed to docker. #89

Fix bash parameter escaping as passed to docker. #89

Conversation

manthey commented Mar 20, 2020

BryonLewis commented Mar 20, 2020

BryonLewis left a comment

Choose a reason for hiding this comment