Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the URLs and fix their formatting #1

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

DaInfLoop
Copy link
Contributor

@DaInfLoop DaInfLoop commented Sep 8, 2024

Fine if you won't do it I will

unless you haven't committed the changes >:(

Summary by Sourcery

Enhance the dialogue messages by adding URLs to provide additional context or information.

Enhancements:

  • Add URLs to the messages in the dialogue configuration to provide context or additional information.

Copy link

sourcery-ai bot commented Sep 8, 2024

Reviewer's Guide by Sourcery

This pull request adds back URLs to the dialogue messages and fixes their formatting. The changes are made in the 'dialogue.py' file, specifically in the messages for the characters Madeline and Bird.

File-Level Changes

Change Details Files
Added URLs to character messages
  • Added a URL to Madeline's message
  • Added a URL to Bird's message
  • Formatted URLs using Slack's link syntax: <URL
text>

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DaInfLoop - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider storing the URLs as constants or in a configuration file to improve maintainability and readability.
  • Remove the duplicate message lines without URLs to avoid confusion and maintain a single source of truth for each dialogue.
  • Provide more context in the commit message and pull request description about the purpose and necessity of these URL additions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@transcental transcental merged commit b4352f9 into transcental:main Sep 8, 2024
1 of 2 checks passed
@transcental
Copy link
Owner

danke

@DaInfLoop DaInfLoop deleted the patch-1 branch September 8, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants