Add timeout parameter propagation from lookup func #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173
As mentioned in the issue, the timeout parameter has been added in the lookup functions and propagated to the appropriate functions.
I have done some small functional / visual testing, which are not included. I only tested MinecraftServer since I don't have a BedrockServer and I tested ping, status and query and also the async variants.
During my small functional testing, I observed that if the URL of the server is a domain name, socket.create_connection can take longer than the specified timeout. This is better described here :
https://stackoverflow.com/questions/12232225/python-3-2-3-socket-takes-longer-to-timeout-than-it-should