Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(distributeBy): distribute rest amount across non-zero weights #111

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

frodeaa
Copy link
Contributor

@frodeaa frodeaa commented Nov 2, 2023

When distributing rest amount across parts we should skip the parts
with zero weight

@frodeaa frodeaa added the bug Something isn't working label Nov 2, 2023
@frodeaa frodeaa changed the title fix(Money.distributeBy): distribute rest amount across non-zero weights fix(distributeBy): distribute rest amount across non-zero weights Nov 2, 2023
When distributing rest amount across parts we should skip the parts
with zero weight
@frodeaa frodeaa marked this pull request as ready for review November 2, 2023 21:31
@frodeaa frodeaa self-assigned this Nov 3, 2023
@frodeaa frodeaa requested a review from andersem November 3, 2023 08:06
@frodeaa frodeaa merged commit 2ce81f1 into master Nov 3, 2023
1 check passed
@frodeaa frodeaa deleted the fix-distribute-by branch November 3, 2023 08:15
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 1.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants