Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make taffy::compute::compute_layout public #263

Closed
nicoburns opened this issue Nov 25, 2022 · 1 comment · Fixed by #266
Closed

Make taffy::compute::compute_layout public #263

nicoburns opened this issue Nov 25, 2022 · 1 comment · Fixed by #266
Labels
usability Make the library more comfortable to use
Milestone

Comments

@nicoburns
Copy link
Collaborator

The combination of #238 and #246 means that it is now almost possible to use taffy without using the Taffy struct at all. One can provide their own storage type implementing LayoutTree with it's own methods for constructing a tree. In theory, one should then be able to call taffy::compute::compute_layout directly on this type. Unfortunately this function isn't public which is currently preventing this use case.

I suggest that we make this method public (perhaps it would be best to re-export as a top-level function?). We may also want to document the existence of the LayoutTree trait.

@alice-i-cecile
Copy link
Collaborator

Yep, I'm on board!

@alice-i-cecile alice-i-cecile added the usability Make the library more comfortable to use label Nov 25, 2022
@nicoburns nicoburns added this to the 0.2.1 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Make the library more comfortable to use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants