Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode Fixes #94

Merged
merged 12 commits into from Jun 4, 2017
Merged

Dark mode Fixes #94

merged 12 commits into from Jun 4, 2017

Conversation

Dave247
Copy link
Contributor

@Dave247 Dave247 commented May 30, 2017

Seeing as the only changes to the files were layout related, I simply cherry-picked the existing two fixes from the master branch into the dark-mode branch

@Dave247
Copy link
Contributor Author

Dave247 commented May 30, 2017 •
edited

There was a very minor new bug that came up by fixing the column select button in small mode, a tiny white line next to the button that I gave up on as I have no idea what was causing it.
nvidia share_2017-05-31_05-34-47

@Dave247
Copy link
Contributor Author

Dave247 commented May 31, 2017 •
edited

I probabbly should explain what the changes in 0132f00 are sorry.

The first lot of changes under ListPanelColumnSelectButton was an undocumented bug, where the area the icon sits was completely white. The simplest fix I found was to change the fill colour to match in Large Mode, however a new problem appeared, as seen in my previous comment. I looked into it but have no idea what is causing the issue though so I don't know how to fix it, but still pushed the change as it looks better now then before.

The second lot of changes under ListPanelSectionHeader were in relation to #80 and #87, where the categories were not changed to match the dark mode design.

The final change of width=max under control=library_search is the simplest way to fix another undocumented issue that I came across myself, where the library_filters button not being aligned to the right of the window if you were to widen it far enough, as shown in the screenshot below (though I don't know why anyone ever would though).
nvidia share_2017-05-31_14-32-24

@Dave247 Dave247 force-pushed the Dark-Mode branch 3 times, most recently from 8b35196 to 525948c Compare June 1, 2017 18:55
@Dave247
Fixed a number of Small Mode bugs
ee7e639 
- ColumnSelectButton is now visable
 - But now a small white line appears on the right side (Unknown bug)

- Changed the library category colors from white to dark as per DirtDiglett#80, DirtDiglett#87 and #4, #7

- Changed the width of the search bar to max as a easy way to align the library filters button to the right.
@Dave247
Fixed a bunch of Web Browser Settings formatting
2eacb44 
- Unhid the description

- Moved the 'browser' region down to make room for description

- Moved the gradient down to cover the 'OverlayHomePageLabel' new position

- Spaced out the auto login for Steam web browser checkbox

- Added a divider to match Steam default skin

- Minor code formatting
@Dave247
Fixed Library background image
fc70eb3 
DirtDiglett#86 #9 Stretched the image to a width of 3840 to accommodate for 4k resolutions
@Js41637 Js41637 merged commit f8df2ea into DirtDiglett:Dark-Mode Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dave247 @Js41637