Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Guild Scheduled Events #1046

Closed
wants to merge 6 commits into from
Closed

Add support for Guild Scheduled Events #1046

wants to merge 6 commits into from

Conversation

NovaFox161
Copy link
Sponsor Member

@NovaFox161 NovaFox161 commented Nov 19, 2021 •
edited
Loading

@NovaFox161 NovaFox161 added enhancement Improvement over an existing feature area/rest Related to the rest module: request-stream, routes, rest-api area/gateway Related to the gateway module: websocket, reconnections, payload handling area/core Related to core module: events, entities, clients, specs PR depends on PR Another PR must be merged before this one labels Nov 19, 2021
@NovaFox161 NovaFox161 added this to the 3.2.2 milestone Nov 19, 2021
@NovaFox161 NovaFox161 mentioned this pull request Jan 12, 2022
Open
@quanticc quanticc removed the PR depends on PR Another PR must be merged before this one label Jan 23, 2022
Doc94
Doc94 reviewed Jan 23, 2022
View reviewed changes
core/src/main/java/discord4j/core/object/audit/ChangeKey.java
/** channel ID for guild scheduled event changed */
public static final ChangeKey<String> LOCATION = changeKey("location", STRING_PARSER);
/** status of guild scheduled event changed */
public static final ChangeKey<Integer> STATUS = changeKey("status", INTEGER_PARSER);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the name of all this maybe can be better a thing like EVENT_STATUS?
and in the same case of STATUS maybe its better not use a Integer and use a enum for the status? https://discord.com/developers/docs/resources/guild-scheduled-event#guild-scheduled-event-object-guild-scheduled-event-status

@Doc94 Doc94 mentioned this pull request Jan 23, 2022
Merged
@quanticc quanticc modified the milestones: 3.2.2, 3.2.3 Feb 14, 2022
@quanticc quanticc modified the milestones: 3.2.3, 3.2.4 Aug 19, 2022
@quanticc quanticc modified the milestones: 3.2.4, 3.2.5 Mar 19, 2023
This was referenced Apr 10, 2023
Closed
Merged
@quanticc quanticc closed this Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doc94 Doc94 Doc94 left review comments

Assignees
No one assigned
Labels
area/core Related to core module: events, entities, clients, specs area/gateway Related to the gateway module: websocket, reconnections, payload handling area/rest Related to the rest module: request-stream, routes, rest-api enhancement Improvement over an existing feature
Projects
None yet
Milestone
3.2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NovaFox161 @Doc94 @quanticc