Implement guild scheduled events #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanticc
requested changes
Apr 17, 2023
common/src/main/java/discord4j/common/store/action/gateway/GuildScheduledEventCreateAction.java
Show resolved
Hide resolved
common/src/main/java/discord4j/common/store/api/layout/GatewayDataUpdater.java
Show resolved
Hide resolved
common/src/main/java/discord4j/common/store/api/layout/DataAccessor.java
Outdated
Show resolved
Hide resolved
This refactoring uses an explicit cast to avoid a build error regarding type inference on the Long class in involved method.
quanticc
reviewed
May 8, 2023
There was a problem hiding this comment.
I've committed some changes to this PR.
We're only missing the core events, that is adding the 5 addHandler calls to DispatchHandlers class and it's good to go
GuildScheduledEventCreate
GuildScheduledEventUpdate
GuildScheduledEventDelete
GuildScheduledEventUserAdd
GuildScheduledEventUserRemove
quanticc
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Uses #1046 and #1133 work, with additional work to implement Guild Scheduled Events functionnalities.
There is still some work to do :
I will publish on my own Maven repository a Snapshot of this PR : https://nexus.klutometis.net/#browse/browse:maven-public:com%2Fdiscord4j
The tag for this snapshot is 2.3.5-EVENTS-SNAPSHOT.
To add this snapshot, add into your gradle.build repositories the following :
Then in your dependencies, specify the version
3.2.5-EVENTS-SNAPSHOT.You will be able to use features from this Pull request.
Justification: https://discord.com/developers/docs/resources/guild-scheduled-event