Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getUser() method to Interaction events #1217

Merged
merged 4 commits into from
May 23, 2024
Merged

Add getUser() method to Interaction events #1217

merged 4 commits into from
May 23, 2024

Conversation

jasonmokk
Copy link
Contributor

@jasonmokk jasonmokk commented May 21, 2024 •
edited

Description:
This PR adds a getUser() method to the InteractionCreateEvent class, which is the base class for all Interaction events. In the ExampleInteractions file, the onSelect and onButton handlers were refactored to use this new getUser() method as opposed to getInteraction().getUser().

Justification:
Closes #1216

@jasonmokk jasonmokk marked this pull request as ready for review May 21, 2024 04:37
@Doc94
Copy link
Member

Doc94 commented May 21, 2024

Hi.
Thanks for the PR. Can you change the target to 3.2.x?

Azn9
Azn9 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@Azn9 Azn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@jasonmokk jasonmokk changed the base branch from master to 3.2.x May 21, 2024 13:15
@jasonmokk
Copy link
Contributor Author

Hi. Thanks for the PR. Can you change the target to 3.2.x?

Done!

@mirayashi
Copy link 

git rebase --onto 3.2.x master add-get-user-method
git push --force

😉

@Azn9 Azn9 added enhancement Improvement over an existing feature area/core Related to core module: events, entities, clients, specs labels May 21, 2024
@Azn9 Azn9 requested a review from Doc94 May 21, 2024 13:55
@Doc94 Doc94 merged commit d23707f into Discord4J:3.2.x May 23, 2024
4 checks passed
@Doc94 Doc94 added this to the 3.2.7 milestone May 23, 2024
Doc94 added a commit that referenced this pull request May 23, 2024
@Doc94
Merge #1217 into 3.3.x
1baa4fe
@jasonmokk jasonmokk deleted the add-get-user-method branch May 23, 2024 14:45
@Azn9 Azn9 modified the milestones: 3.2.7, 3.3.0 Jun 11, 2024
Azn9 pushed a commit to Azn9/Discord4J that referenced this pull request Jun 17, 2024
@jasonmokk @Azn9
Add getUser() method to Interaction events (Discord4J#1217)
abc25f8 
* Add getUser() method to Interaction events

* Update ExampleInteractions

* Adjust implementation

* Add documentation
Azn9 pushed a commit to Azn9/Discord4J that referenced this pull request Jun 17, 2024
@jasonmokk @Azn9
Add getUser() method to Interaction events (Discord4J#1217)
ea54025 
* Add getUser() method to Interaction events

* Update ExampleInteractions

* Adjust implementation

* Add documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doc94 Doc94 Doc94 approved these changes

@Azn9 Azn9 Azn9 approved these changes

Assignees
No one assigned
Labels
area/core Related to core module: events, entities, clients, specs enhancement Improvement over an existing feature
Projects
3.3.0 Release
Status: Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Add a "getUser" method on the Interaction events
4 participants
@jasonmokk @Doc94 @mirayashi @Azn9