-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getUser() method to Interaction events #1217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. |
Azn9
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Done! |
😉 |
Doc94
reviewed
May 21, 2024
core/src/main/java/discord4j/core/event/domain/interaction/InteractionCreateEvent.java
Show resolved
Hide resolved
Doc94
approved these changes
May 21, 2024
Azn9
pushed a commit
to Azn9/Discord4J
that referenced
this pull request
Jun 17, 2024
* Add getUser() method to Interaction events * Update ExampleInteractions * Adjust implementation * Add documentation
Azn9
pushed a commit
to Azn9/Discord4J
that referenced
this pull request
Jun 17, 2024
* Add getUser() method to Interaction events * Update ExampleInteractions * Adjust implementation * Add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
Related to core module: events, entities, clients, specs
enhancement
Improvement over an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a
getUser()
method to theInteractionCreateEvent
class, which is the base class for all Interaction events. In theExampleInteractions
file, theonSelect
andonButton
handlers were refactored to use this newgetUser()
method as opposed togetInteraction().getUser()
.Justification:
Closes #1216