refactor: adjusted naming of NITRO_STICKER_PACKS_GET #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Doc94 sorry totally destroyed my last branch with git rebase, guess i need some more practice in that . Therefore here the new PR |
Doc94
added
the
area/rest
Doc94
approved these changes
May 21, 2024
|
I add again the NITRO_STICKER_PACKS_GET but with a deprecated notice for avoid break any external call of this public field in 3.2.x but when this is merge in 3.3.x the deprecated method need to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR solves the issue #1192 by renaming the package into STICKER_PACKS_GET since a nitro subscription is not needed anymore. The Docu was adjusted accordingly
Justification: PR solves the issue #1192
note: old PR #1218 was closed since rebase did not work as expected