refactor: adjusted naming of NITRO_STICKER_PACKS_GET #1218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify channel hierarchy in preparation for threads * Use 'TopLevel' names instead of temp names, remove duplicate docs * Add deprecation docs * Add class docs * Make CategorizableChannel extend TopLevelGuildChannel * Make breaking channel hierarchy changes * (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes * Don't deprecate GuildChannel#getEffectivePermissions * Remove BaseTopLevelGuildChannel, add license headers, docs * Remove unused imports * Remove unused imports Co-authored-by: quanticc <abarcab.ivan@gmail.com>
* Initial work on threads * More work on threads * Modify channel hierarchy in preparation for threads * Use 'TopLevel' names instead of temp names, remove duplicate docs * Add deprecation docs * Add class docs * Make CategorizableChannel extend TopLevelGuildChannel * Make breaking channel hierarchy changes * (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes * Don't deprecate GuildChannel#getEffectivePermissions * Remove BaseTopLevelGuildChannel, add license headers, docs * Remove unused imports * Remove unused imports * Use new channel hierarchy
Fix #1014
Fix code style Migrate mapPossibleOverwrites usage remove legacy specs for stage channels (use new api instead) Close #954
Close #1029
Fix code style Migrate mapPossibleOverwrites usage remove legacy specs for stage channels (use new api instead) Close #954
* Build with JDK 17 Still targeting Java 8. * Upgrade to gradle 7.4 * Add .github/workflows folder to pull_request.paths Co-authored-by: quanticc <abarcab.ivan@gmail.com>
Message::startThread TopLevelGuildMessageChannel::startThread ThreadChannel::join ThreadChannel::leave ThreadChannel::addMember ThreadChannel::removeMember Add ThreadChannel.Type enum Include an example class
Co-authored-by: quanticc <abarcab.ivan@gmail.com>
* Add store actions for threads, implement thread member caching * Add accessor to EntityRetriever for threads and their members * Add ThreadMember accessors to ThreadChannel * Remove unavailable route for listing active threads * Add listing methods for threads * Don't save thread channels to GuildContent * Update thread saving in LegacyStoreLayout and add missing types to local enum * Add thread event listener to ExampleThread bot * Add methods to ReactiveEventAdapter * Fix missing closing quotes in javadoc crashing jdk17 build * Use default impl for new DataAccessor methods * Update ThreadMember comments as TODOs --------- Co-authored-by: quanticc <abarcab.ivan@gmail.com>
Apply changes required by Discord4J/discord-json#134 Close #1009
…#1121) * feat(core): promote `ReactionEmoji.Custom#asFormat` to `ReactionEmoji` * feat(core): standardize creation of displayable string for custom emoji
…usability in external projects (#1122)
* Add first forum channel entities * Implement forum channels * Make channel flags part of the Channel class * Make wrapped list empty when not present instead of using Optional * Multiple changes required for PR : * Moved members in ForumChannel * Added documentation in added enums * Fix Optional usage in some members * Removed ForumThreadMessage in favor of ForumThreadMessageCreateSpec * Fix documentation typo * Update documentation regarding channel flags * Make getDefaultAutoArchiveDuration optional * Add missing events and mappings regarding forum channels * Update documentation on channel flags * Add ExampleForum as an example of how to create a forum and start using it * Add parent_id env var to forum channel example
Regression after #1128
* Support rateLimitPerUser for Guild Messages Channel * Move getRateLimitPerUser to CategorizableChannel and include ThreadChannel
…annel is a forum channel (#1175) * Fix cast exception when getting parent channel for threads in forum channels * Add documentation on ThreadChannel#getParent methods
This commit fixes some fields in ResolvedChannel that are not mandatory but were marked as. It also includes a missing field in ResolvedMember and ResolvedChannel. Requires a new version of discord-json (probably 1.7.8) Fixes #1171
* Add store actions for threads, implement thread member caching * Add accessor to EntityRetriever for threads and their members * Add ThreadMember accessors to ThreadChannel * Remove unavailable route for listing active threads * Add listing methods for threads * Don't save thread channels to GuildContent * Update thread saving in LegacyStoreLayout and add missing types to local enum * Add thread event listener to ExampleThread bot * Add methods to ReactiveEventAdapter * Fix missing closing quotes in javadoc crashing jdk17 build * Use default impl for new DataAccessor methods * Update ThreadMember comments as TODOs --------- Co-authored-by: quanticc <abarcab.ivan@gmail.com>
… into feature/rename-stickerpack-1192 # Conflicts: # common/src/main/java/discord4j/common/store/legacy/StateHolder.java # core/src/main/java/discord4j/core/event/dispatch/ThreadDispatchHandlers.java # core/src/main/java/discord4j/core/object/entity/channel/BaseTopLevelGuildChannel.java # core/src/main/java/discord4j/core/object/entity/channel/CategorizableChannel.java # core/src/main/java/discord4j/core/object/entity/channel/MessageChannel.java # core/src/main/java/discord4j/core/object/entity/channel/ThreadChannel.java # core/src/main/java/discord4j/core/spec/EmbedCreateSpecGenerator.java # core/src/main/java/discord4j/core/spec/StageChannelCreateSpecGenerator.java # core/src/main/java/discord4j/core/spec/StageChannelEditSpecGenerator.java # core/src/main/java/discord4j/core/util/MentionUtil.java # core/src/test/java/discord4j/core/ExampleThread.java # rest/src/main/java/discord4j/rest/entity/RestStageInstance.java # rest/src/main/java/discord4j/rest/route/Routes.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR solves the issue #1192 by renaming the package into STICKER_PACKS_GET since a nitro subscription is not needed anymore. The Docu was adjusted accordingly
Justification: PR solves the issue #1192