-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice prototype for 3.1 #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a more symmetric voice gateway implementation with resume and automatic reconnect capabilities. Move some classes to common module as they are used in gateway+voice. Allow customizing the send and receive task factories, UdpClient and schedulers. Move the previous implementation under a FSM prefix.
[ci skip]
quanticc
added
enhancement
Improvement over an existing feature
area/gateway
Related to the gateway module: websocket, reconnections, payload handling
area/voice
Related to the voice module
labels
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/gateway
Related to the gateway module: websocket, reconnections, payload handling
area/voice
Related to the voice module
enhancement
Improvement over an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently toying with some changes to voice module in 3.1:
Attempting to cover the following tickets: #536 #523
As this PR only takes care of translating the current impl to a more malleable pattern, only some of the items in #427 are to be covered:
Pending work (to be handled in separate PRs/commits to master)
And beyond the scope of this PR:
Since we only push snapshots on release and maintenance branches, testing this is only possible through jitpack.