Implement degraded client notice & legacifying of messages for LunarClient #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granny
approved these changes
Oct 27, 2021
Scarsz
approved these changes
Nov 9, 2021
Vankka
commented
Nov 22, 2021
This was referenced Mar 8, 2022
This seems to be fixed now? (Please correct me if I'm wrong) |
|
Will check again, soon |
Vankka
added a commit
that referenced
this pull request
Apr 27, 2022
…sages completely. Related to #1294
|
Confirmed that LunarClient fixed it, took them long enough. Next version has the notice & click/hover component removal taken out |
|
the message has not been removed. or at least, i'm still getting notifications in the log that people have been shown the warning. |
|
The latest release still has it, it will be gone in the next version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users stumbling upon this PR,
Due to LunarClient hiding messages containing click to copy functionality (this also happens for vanilla commands, eg. the
/seedcommand) and not showing any intention to fix this even after being notified of the issue (multiple times over 5+ months), we have decided to add a notification for users using LunarClient letting them know that some commands may not work as expected, as this functionality should work as it does on the vanilla client instead of completely hiding the message.Image of their support manually closing a ticket without comment regarding this issue. The ticket was closed before the last message. The last message was sent in hopes of response to no avail.