Fixed Blacklist/Whitelist not being resepected #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tSelectedRoles() of the same scope and attempts to get the highest role the user has that is present in the selected roles. Changes onRequest in PlaceholderAPIExpansion.java to use this new method rather than just fetching their highest role and ignoring selectedRoles. Additionally removed logic getting a list of selected rules as it is not needed here.
Dinty1
requested changes
Jun 29, 2024
|
Sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1557
Added getTopSelectedRole() method to DiscordSRV.java. Method calls getSelectedRoles() of the same scope and attempts to get the highest role the user has that is present in the selected roles.
Changes onRequest in PlaceholderAPIExpansion.java to use this new method rather than just fetching their highest role and ignoring selectedRoles. Additionally, removed logic getting a list of selected rules as it is not needed here.