Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing of interaction followup send #626

Open
onerandomusername opened this issue Jul 16, 2022 · 0 comments · May be fixed by #1193
Open

Improve typing of interaction followup send #626

onerandomusername opened this issue Jul 16, 2022 · 0 comments · May be fixed by #1193
Assignees
@shiftinv
Labels
feature request Request for a new feature help wanted Extra attention is needed

Comments

@onerandomusername
Copy link
Member

Summary

Interaction.followup.send should have overloads to always return a message

What is the feature request for?

The core library

The Problem

Interaction.followup.send doesn't say it always returns a message instance. Additionally, avatar_url and username are not supported for followups.

The Ideal Solution

Interaction.followup.send should be typed to always return a disnake.Message instance, and not take a wait, username, or avatar_url parameter, at least in typing overloads.

The Current Solution

No response

Additional Context

No response
@onerandomusername onerandomusername added the feature request Request for a new feature label Jul 16, 2022
@onerandomusername onerandomusername mentioned this issue Jul 16, 2022
Open
3 tasks
@onerandomusername onerandomusername added the help wanted Extra attention is needed label Jul 17, 2022
@shiftinv shiftinv self-assigned this Aug 6, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Aug 28, 2022
@shiftinv shiftinv modified the milestones: disnake v2.6, disnake v2.7 Sep 1, 2022
@shiftinv shiftinv removed this from the disnake v2.8 milestone Feb 5, 2023
@elenakrittik elenakrittik linked a pull request May 15, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiftinv shiftinv

Labels
feature request Request for a new feature help wanted Extra attention is needed
Projects
disnake
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Improve webhook typing. elenakrittik/disnake
2 participants
@shiftinv @onerandomusername