fix: fastchess output for startpos #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mh just leave it empty? |
looks kinda ugly ngl, extra comma and all:
i think it makes more sense to just put in startpos, so people know what opening is used |
|
well you can also rewrite it so that |
well sure but that would complicate the code more than it needs to, i think just adding startpos is simpler and more informative |
|
well the field name is "book name", if no book is given, the name should be empty and not "startpos" as that is not the name of the book |
|
updated |
|
what? you still have "startpos" |
|
updated ver 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.