Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight Character, String or Regex #41

Open
windymilla opened this issue Dec 15, 2023 · 4 comments
Open

Highlight Character, String or Regex #41

windymilla opened this issue Dec 15, 2023 · 4 comments
Assignees
Labels
core feature Required for basic PPing

Comments

@windymilla
Copy link
Collaborator

windymilla commented Dec 15, 2023

In GG1 Search menu

@windymilla windymilla added the core feature Required for basic PPing label Feb 18, 2024
@tangledhelix
Copy link
Collaborator

I'm looking into this.

@tangledhelix
Copy link
Collaborator

Key bind note on this: in GG1 the keybind is defined as Ctrl+$::altkeyname+h, which on Mac comes out to Ctrl+Command+h; an unusual combination on Macs; investigate if another combo is open or would make more sense (for this and the other platforms). I assume this is Ctrl-Alt-h on Windows (would have to verify).

The problem noted in another ticket about the Opt key not seeming to work is an issue to look into further, it might help here. Although another note is that Cmd-Opt-h is consumed by the global "Hide Others" command, taken by the windowserver and not available to remap.

@tangledhelix
Copy link
Collaborator

That said, Ctrl-Cmd-h might work on Mac and be available, so it may be simplest to actually leave as-is. It just doesn't follow our GG2 convention.

@windymilla
Copy link
Collaborator Author

Happy if you decide not to allocate a key binding at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature Required for basic PPing
Projects
None yet
Development

No branches or pull requests

2 participants