Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1713 amp renderer #2018

Merged
merged 4 commits into from
Nov 22, 2018
Merged

Feature/1713 amp renderer #2018

merged 4 commits into from
Nov 22, 2018

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Nov 22, 2018

Related issues

#1713

Short description and why it's useful

@NataliaTepluhina please update the docs:
Google Advanced Mobile pages are available with Vue Storefront 1.6. By default, the Product and Category pages do support AMP. To get the AMP page You should use the following URL:
http://localhost:3000/c/hoodies-and-sweatshirts-24 -> http://localhost:3000/amp/c/hoodies-and-sweatshirts-24.
The discovery links are added as <link rel="amphtml" .... The landing pages then distribute the traffic to canonical Vue Storefront links to enable all the features to work (by definition AMP doesn't support any additional JavaScript).

Important notice: AMP renderer works ONLY IN PRODUCTION MODE as the Advanced Content Output Options - specifically index.html template switching works only in production. In development mode, there can be CSR/SSR issues so don't even test it in development mode :-)

AMPHTML templates are provided by the src/themes/default-amp special purpose theme which inherits some parts from default theme

Screenshots of visual changes before/after (if there are any)

screenshot 2018-11-22 12 47 05
screenshot 2018-11-22 12 46 58

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@pkarw pkarw merged commit 5c215a4 into develop Nov 22, 2018
@pkarw pkarw deleted the feature/1713_amp_renderer branch November 29, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant