Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bootstrap javascript from code example #170

Closed
MarkusH opened this issue Nov 8, 2014 · 3 comments
Closed

Remove bootstrap javascript from code example #170

MarkusH opened this issue Nov 8, 2014 · 3 comments
Labels
status: accepted type: bug

Comments

@MarkusH
Copy link
Contributor

MarkusH commented Nov 8, 2014

Adding the bootstrap.min.js file in http://tutorial.djangogirls.org/css/README.html#install-boostrap leads to an error:

Uncaught Error: Bootstrap's JavaScript requires jQuery

In fact, this is explained and shown in the bootstrap starter template: http://getbootstrap.com/getting-started/#template
@oinopion
Copy link
Contributor

oinopion commented Nov 9, 2014

Do we actually need bootstrap's JS?

@MarkusH
Copy link
Contributor Author

MarkusH commented Nov 9, 2014

I don't think we need Bootstrap's JS stuff. But we should drop the reference in the template in that case.

@MarkusH MarkusH mentioned this issue Nov 11, 2014
Closed
@olasitarska olasitarska changed the title Missing jQuery in post_list.html Remove bootstrap javascript from code example Jan 15, 2015
@aniav aniav closed this as completed in d366529 Feb 12, 2015
@aniav
Copy link
Member

aniav commented Feb 12, 2015

Removed. Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oinopion @aniav @MarkusH @olasitarska