Validate all elements of ArrayType #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @bostanio, thank you for the contribution 💪 Looks good to me, please take a look at my suggestion but the decision is all yours. Also, could you please add yourself to the changelog?
| @@ -24,7 +24,7 @@ def validate_each(record, attribute, value) | |||
| when :json | |||
| strategy.call(attribute, record.errors, value.errors) if value.invalid? | |||
| when :array | |||
| record.errors.add(attribute, :invalid) if value.any?(&:invalid?) | |||
| record.errors.add(attribute, :invalid) if value.select(&:invalid?).present? | |||
There was a problem hiding this comment.
Suggested change
| record.errors.add(attribute, :invalid) if value.select(&:invalid?).present? | |
| record.errors.add(attribute, :invalid) if value.select(&:invalid?).any? |
I guess we still can use .any? just to make the line shorter
There was a problem hiding this comment.
Personally I'd use present? as we care that the result is non-empty or not. Not much in it either way.
There was a problem hiding this comment.
In this particular case .select cannot return nil 🙂
|
Any chance we can do a point release of 0.6.2 for this? |
|
Sure, I've just rolled it out to RubyGems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
any?to validate ArrayType. That has the effect elements after the first invalid element don't get validated and their errors collection isn't populated.This fix makes sure to call
invalid?on every element of the array before setting an error on the parent record.