Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change emDelimiter to * to fix having only part of word in italic #490

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

nats12
Copy link
Contributor

@nats12 nats12 commented Oct 18, 2023

Overview

This PR changes the emDelimiter to use * instead of _. The motivation behind this was the discovery of #324.

Closes #324.

PR Checklist

Test plan

  • In the Storybook build, italic Markdown output is now shown with the * delimiter

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for doist-typist ready!

Name Link
🔨 Latest commit ad5d80b
🔍 Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/652ff765c9725500086ad532
😎 Deploy Preview https://deploy-preview-490--doist-typist.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nats12 nats12 requested a review from rfgamaral October 18, 2023 15:14
@rfgamaral rfgamaral changed the title fix: Change emDelimiter to * to fix having only part of word in italic fix: Change emDelimiter to * to fix having only part of word in italic Oct 19, 2023
Copy link
Member

@rfgamaral rfgamaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@nats12 nats12 merged commit 7496ff2 into main Oct 19, 2023
12 checks passed
@nats12 nats12 deleted the natalie/fix-324 branch October 19, 2023 09:41
doistbot added a commit that referenced this pull request Oct 19, 2023
## [2.1.2](v2.1.1...v2.1.2) (2023-10-19)

### Bug Fixes

* Change `emDelimiter` to `*` to fix having only part of word in italic ([#490](#490)) ([7496ff2](7496ff2))
@doistbot
Copy link
Member

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doistbot doistbot added the released Pull requests that have been released to production label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Pull requests that have been released to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Italic gets replaced by underscore characters if only parts of words are italic
3 participants