BUG: Accounting CSV Export values not quoted when including ','

[paddatrapper]

Bug

When lines from the accounting ledger are exported, some values include a comma as a thousands separator. This should be quoted to avoid the value being split into two columns.

Environment

• Version: 9.0.3
• OS: Debian Stretch
• Web server: Nginx
• PHP: 7.0.33-0+deb9u3
• Database: MariaDB
• URL(s): /accountancy/bookkeeping/list.php

Expected and actual behaviour

When a transaction with a value greater than 999 is exported, it should be exported with quotation marks around it so that it is treated as a single column and not two. Currently the value is not quoted and the value is broken up over two columns.

Expected CSV line:

1,07052019,BankId 7 - Miscellaneous payments 5,Copy Express vinyl sticker,53,,"1,230.00",0.00,"1,230.00",BQ

Actual output:

1,07052019,BankId 7 - Miscellaneous payments 5,Copy Express vinyl sticker,53,,1,230.00,0.00,1,230.00,BQ

Steps to reproduce the behavior

Export a filtered CSV file of a ledger containing a transaction with a value greater than 999.