Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private routing hints #7

Open
seth586 opened this issue Jan 13, 2023 · 2 comments
Open

Support private routing hints #7

seth586 opened this issue Jan 13, 2023 · 2 comments

Comments

@seth586
Copy link

seth586 commented Jan 13, 2023

Right now, inbound liquidity on a private channel will not work unless a private routing hint is added.

@sommerfelddev
Copy link

According the lnd rest api docs for AddInvoice it seems to be as easy as adding private=true in the rest api request.

According to my shallow investigation, it should be added in these places:

ligess/router.js

Lines 47 to 53 in d8c7162

const invoice = await unaWrapper.createInvoice({
amountMsats: msat,
descriptionHash: crypto
.createHash('sha256')
.update(metadata)
.digest('hex')
})

https://github.com/blc-org/una/blob/c4ae26440081b29f8a0f3b950a1be948dc9cb872/bindings/una-js/index.d.ts#L22-L32

Maybe this should be behind an environment variable like LIGESS_LND_PRIVATE_INVOICES. @Dolu89 what do you think?

@Dolu89
Copy link
Owner

Dolu89 commented Feb 24, 2023

Ligess currently uses the original node.js of Una (master branch). This https://github.com/blc-org/una/blob/c4ae26440081b29f8a0f3b950a1be948dc9cb872/bindings/una-js/index.d.ts#L22-L32 is part of the new version of Una written in Rust. It's not finished, so not deployed yet.

The current node.js version of Una wasn't supposed to be updated, but I'll see how to add this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants