Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "stats" button to Toolbar to control which stats to show on each ContextNode call graph node #478

Open
8 tasks
Domiii opened this issue Mar 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Domiii
Copy link
Owner

Domiii commented Mar 18, 2021

  • add new stats button to Toolbar for toggling stats information on ContextNode, when clicked...:
    • store statsMask in GraphRoot state
    • call setStatsMask on all ContextNode components
  • add new Enum StatsMask
  • Enum already provides several bit mask features for this. Missing operations need to be added (such as has, add and delete).
  • Add a "Settings" (⚙️) button. When clicked toggles new SettingsPanel right under the Toolbar
    • Add StatsPanel to SettingsPanel
      • Allow choosing which stats to show when Stats are enabled (one checkbox per stat)
        • This should support all types of stats from StatsByContextQuery.get* functions

Explanation:

  • A mask in this case refers to a "bit mask", an integer housing one boolean per individual bit.

Future Work (don't do for now)

  • only dp.queryImpl.statsByContext.subscribe() when statsEnabled (can add that logic in GraphRoot.update)
    • requires extra level of bookkeeping
@Domiii Domiii added enhancement New feature or request priority small This issue should not take a lot of code or time to fix. labels Mar 18, 2021
@MiccWan
Copy link
Collaborator

MiccWan commented Mar 31, 2021

This could be done more easily after merging #482.

@MiccWan MiccWan added the blocked Cannot currently continue on this due to other unresolved issues. label Mar 31, 2021
@MiccWan MiccWan removed the blocked Cannot currently continue on this due to other unresolved issues. label Apr 7, 2021
@Domiii Domiii assigned Nehcled and unassigned MiccWan May 7, 2021
@Domiii Domiii removed the small This issue should not take a lot of code or time to fix. label May 7, 2021
@Domiii Domiii removed the priority label Feb 20, 2022
@Domiii Domiii changed the title Add "stats" button to Toolbar to control whether to show ContextNode stats Add "stats" button to Toolbar to control which stats to show on each ContextNode call graph node Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants