Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isppa and heating maps are incorrectly transformed to MNI space #23

Closed
KTZ228 opened this issue Jun 6, 2023 · 2 comments
Closed

Isppa and heating maps are incorrectly transformed to MNI space #23

KTZ228 opened this issue Jun 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@KTZ228
Copy link
Collaborator

KTZ228 commented Jun 6, 2023

Caused by smooth_and_crop_layered & smooth_and_crop_skull functions not applying transforms to MNI transformation matrix but only to the structural data itself.
Since you would only transform subject data MNI space when looking at groups, it will not affect the individual results.

@KTZ228
Copy link
Collaborator Author

KTZ228 commented Jul 4, 2023

When comparing *final_medium_masks_orig* to *final_medium_masks_MNI* we can see that incorrect labels such as neural tissue are placed alongside the borders of bodies in the latter whereas these were not yet there in the former. Indicating that this issue is caused by the translation of the segmented mask to MNI space.

@KTZ228
Copy link
Collaborator Author

KTZ228 commented Jul 26, 2023

This is fixed, will submit in a future pull request, additional comments explaining the issue and fix can be found here:
simnibs/simnibs#175

@jkosciessa jkosciessa added the bug Something isn't working label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants