Add never suspend annotation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tycale
force-pushed
the
add_never_suspend_annotation
branch
from
5b525e5
to
2d6abd9
Compare
raffis
reviewed
Jun 12, 2024
raffis
approved these changes
Jun 12, 2024
|
We might name the annotation |
Signed-off-by: Thibault Gérondal <thibault@initia.cloud>
Tycale
force-pushed
the
add_never_suspend_annotation
branch
from
2d6abd9
to
87037f1
Compare
|
I also do prefer |
|
Thx for the contribution |
|
@raffis Hey, could you create a a new release, a v0.3.2 that I could use with this new feature ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Situation
Currently, there is no simple way to exclude specific pods from being suspended.
Proposal
Introduce a concise annotation to easily identify and exclude pods that should not be suspended.