Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Labels in Last Graph in "The basics of double/debiased machine learning" #68

Closed
ShreyDixit opened this issue Feb 10, 2022 · 4 comments · Fixed by #69
Closed

Wrong Labels in Last Graph in "The basics of double/debiased machine learning" #68

ShreyDixit opened this issue Feb 10, 2022 · 4 comments · Fixed by #69
Labels
documentation Improvements or additions to documentation

Comments

@ShreyDixit
Copy link

Description of the issue or change proposal

The labels in the legend of the last graph on the page are in the wrong order.

image

I tried running the code to generate the graph on my system but I failed to reproduce it. The graph that I got after running the code was the right one.
image

I even tried to compile the code on my system to generate the HTML files but it still generated the right graph.
Below is my system info that I got after running the following code:

import platform; print(platform.platform())
import sys; print("Python", sys.version)
import doubleml; print("DoubleML", doubleml.__version__)
import sklearn; print("Scikit-Learn", sklearn.__version__)
import seaborn; print("Seaborn", seaborn.__version__)
Linux-5.11.0-41-generic-x86_64-with-glibc2.10
Python 3.8.8 (default, Apr 13 2021, 19:58:26) 
[GCC 7.3.0]
DoubleML 0.4.1
Scikit-Learn 0.24.1
Seaborn 0.11.1

Comments, context or references

No response

@ShreyDixit ShreyDixit added the documentation Improvements or additions to documentation label Feb 10, 2022
@MalteKurz
Copy link
Member

So the problem is, that you locally get the correct labels / label order but on the deployed page the labels are wrong?

@ShreyDixit
Copy link
Author

Yes, precisely.

@MalteKurz
Copy link
Member

Explicitly setting the labels fixes the issue, see #69.

@MalteKurz
Copy link
Member

The issue was successfully fixed, see the dev version https://docs.doubleml.org/dev/guide/basics.html. I will trigger a deploy to stable...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants