Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How much do we hide the JSON nature of the underlying representation? #5

Open
DougBurke opened this issue Aug 4, 2018 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@DougBurke
Copy link
Owner

This is related to #4 but worth a separate issue.

At present the types are a "thin shim" around the Aeson/JSON representation. This allows some flexibility which could be useful - such as manually adding or changing elements if the VegaLite schema has changed from that supported by this module - but ends up feeling like you are just using Map Text Text with little guidance from the types. i do not have a suggestion for what a more-typed alternative would be.

@DougBurke DougBurke added help wanted Extra attention is needed question Further information is requested labels Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant