Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default components in SdcProvider #329

Open
1 of 2 tasks
a-kleinf opened this issue Feb 2, 2024 · 1 comment
Open
1 of 2 tasks

Change default components in SdcProvider #329

a-kleinf opened this issue Feb 2, 2024 · 1 comment
Labels
enhancement New feature or request v2 Version 2 is affected

Comments

@a-kleinf
Copy link
Collaborator

a-kleinf commented Feb 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Feature idea

During "default" instantiation of class SdcProvider - "default_sdc_provider_components" including several role-providers are used.
This behaviour should be changed since a loaded Mdib is modified in a way, that Descriptors are added.
Current implementation forces an application to explicitly deactivate the loaded role providers by setting/implementing the parameter "default_components".

If such default components/roles are needed during e.g. unittests in sdc11073, the mechanism of "specific_components" should be used instead of loading them by default.

-> it must be investigated if the implementation of role provider is affected by and suitable with multi mds Mdibs?
-> descriptions of the behaviour is not document, e.g. docstring for the parameter "default_components"

Alternatives

Implementation idea

No response

Participation

  • I am willing to submit a pull request to implement this feature.

Link to the idea discussion

No response

@a-kleinf a-kleinf added enhancement New feature or request v2 Version 2 is affected labels Feb 2, 2024
@a-kleinf
Copy link
Collaborator Author

a-kleinf commented Feb 6, 2024

maybe delete AudioPause and ClockProvider etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 Version 2 is affected
Projects
None yet
Development

No branches or pull requests

1 participant