gl: improve error messages for invalid IDs

DragonMinded · Jun 21, 2023 · cf5ba23 · cf5ba23
1 parent 279fdc2
commit cf5ba23
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/src/GL/array.c b/src/GL/array.c
@@ -407,7 +407,8 @@ void glDeleteVertexArrays(GLsizei n, const GLuint *arrays)
 
     for (GLsizei i = 0; i < n; i++)
     {
-        assertf(arrays[i] == 0 || is_valid_object_id(arrays[i]), "Not a valid array object: %#lx", arrays[i]);
+        assertf(arrays[i] == 0 || is_valid_object_id(arrays[i]), 
+            "Not a valid array object: %#lx. Make sure to allocate IDs via glGenVertexArray", arrays[i]);
 
         gl_array_object_t *obj = (gl_array_object_t*)arrays[i];
         if (obj == NULL) {
@@ -425,7 +426,8 @@ void glDeleteVertexArrays(GLsizei n, const GLuint *arrays)
 void glBindVertexArray(GLuint array)
 {
     if (!gl_ensure_no_immediate()) return;
-    assertf(array == 0 || is_valid_object_id(array), "Not a valid array object: %#lx", array);
+    assertf(array == 0 || is_valid_object_id(array), 
+        "Not a valid array object: %#lx. Make sure to allocate IDs via glGenVertexArray", array);
 
     gl_array_object_t *obj = (gl_array_object_t*)array;
 

diff --git a/src/GL/buffer.c b/src/GL/buffer.c
@@ -17,7 +17,8 @@ GLboolean glIsBufferARB(GLuint buffer)
 void glBindBufferARB(GLenum target, GLuint buffer)
 {
     if (!gl_ensure_no_immediate()) return;
-    assertf(buffer == 0 || is_valid_object_id(buffer), "Not a valid buffer object: %#lx", buffer);
+    assertf(buffer == 0 || is_valid_object_id(buffer), 
+        "Not a valid buffer object: %#lx. Make sure to allocate IDs via glGenBuffersARB", buffer);
 
     gl_buffer_object_t *obj = (gl_buffer_object_t*)buffer;
 
@@ -47,7 +48,8 @@ void glDeleteBuffersARB(GLsizei n, const GLuint *buffers)
 
     for (GLsizei i = 0; i < n; i++)
     {
-        assertf(buffers[i] == 0 || is_valid_object_id(buffers[i]), "Not a valid buffer object: %#lx", buffers[i]);
+        assertf(buffers[i] == 0 || is_valid_object_id(buffers[i]), 
+            "Not a valid buffer object: %#lx. Make sure to allocate IDs via glGenBuffersARB", buffers[i]);
 
         gl_buffer_object_t *obj = (gl_buffer_object_t*)buffers[i];
         if (obj == NULL) {

diff --git a/src/GL/texture.c b/src/GL/texture.c
@@ -558,7 +558,8 @@ GLboolean glIsTexture(GLuint texture)
 void glBindTexture(GLenum target, GLuint texture)
 {
     if (!gl_ensure_no_immediate()) return;
-    assertf(texture == 0 || is_valid_object_id(texture), "Not a valid texture object: %#lx", texture);
+    assertf(texture == 0 || is_valid_object_id(texture),
+        "Not a valid texture object: %#lx. Make sure to allocate IDs via glGenTextures", texture);
 
     gl_texture_object_t **target_obj = NULL;
 
@@ -625,7 +626,8 @@ void glDeleteTextures(GLsizei n, const GLuint *textures)
 
     for (uint32_t i = 0; i < n; i++)
     {
-        assertf(textures[i] == 0 || is_valid_object_id(textures[i]), "Not a valid texture object: %#lx", textures[i]);
+        assertf(textures[i] == 0 || is_valid_object_id(textures[i]),
+            "Not a valid texture object: %#lx. Make sure to allocate IDs via glGenTextures", textures[i]);
 
         gl_texture_object_t *obj = (gl_texture_object_t*)textures[i];
         if (obj == NULL) {