Add borders and aspect ratio support to resolution_t #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unstable
By edges I mean literally the edges of the screen Also various fixes to display.h/c Deprecated (deleted) VI_regs within regsinternal.h because there's now a vi.h internal library
SpookyIluha
force-pushed
the
unstable-vi-borders
branch
from
8d6b4bc
to
02798bb
Compare
rasky
force-pushed
the
unstable-vi-borders
branch
from
562de70
to
9237c96
Compare
|
I'm working on this with @SpookyIluha, we are testing many edge cases. Putting back to draft status for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, there's now a way to tell libdragon to have no borders in the output (useful for emulators and modern TV's)
Also with this PR users can add hardware VI borders around the framebuffer to midigate overscan on most CRT TV's
Borders scale the image down instead of cropping it, so that the framebuffer is fully visible.
There's also now an aspect ratio setting which can be used to achieve letterbox widescreen.
With this PR NTSC/PAL/M-PAL systems and monitors should output identical pictures.