This repository has been archived by the owner on Apr 7, 2021. It is now read-only.
Feature/invisible players #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed invisible elytras with no skin Removed offline code
Fixes some cape returns
|
elytras display fine on myself...maybe you could check what capedata the client sends when no cape is applied? |
|
Surely if you set an elytra as the cape it will display an elytra at all times |
|
When I tested, players who did not have an cape, when wearing an elytra it appears invisible. Elytras are included on the cape texture. I thought this to be due to serializing a skin with the cape set to ImageData.EMPTY. Also, elytras display fine on yourself See the example below. However I may have been wrong. |
lukeeey
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most invisible player issues caused by a null game profile on some player list packets. I also added a default cape texture as returning an ImageData.EMPTY will cause elytras to be invisible. Then also fixed cape scaling as bedrock only support 64x32 capes.
Also reverted skins being disabled in offline auth.