Proper Invalid Bankswitch Emulation #164
Conversation
The CPU-halting is broken, so bad opcodes and RST 38h hacks are broken.
still broke
i suck at this
Also I removed the rest of the remnants of my previous broken toggle menu.
| @@ -145,9 +145,6 @@ void powerHandler(u32 value, void* user_data) { | |||
| } | |||
| fifoSendValue32(FIFO_SYSTEM, battery); | |||
| break; | |||
| case PM_DSI_HACK: | |||
| __dsimode = true; | |||
| break; | |||
There was a problem hiding this comment.
Maybe libnds has evolved, but can I ask why you had to remove this?
| @@ -31,7 +31,6 @@ DEBUG := -g | |||
| CFLAGS := -Wall -Wno-psabi -DNO_VIZ \ | |||
| -march=armv5te -mtune=arm946e-s -fomit-frame-pointer\ | |||
| -ffast-math -O3 $(ARCH) $(DEBUG) \ | |||
| -DVERSION_STRING=\"`git describe --always --abbrev=4`\"\ | |||
There was a problem hiding this comment.
I guess this didn't work for you? I'd really prefer to keep this though...
There was a problem hiding this comment.
Nevermind, I see you added it back later...
|
Also, so I can test this later, can you give an example of a homebrew that this fixes? |
|
I don't have a specific example, but I know there are a few. Also, I
removed the DSi lines because they kept me from compiling successfully for
some reason. I'm guessing you already saw what I was trying to do at first,
but I couldn't get it to work for some reason... it just wasn't
cooperating. Probably for the best, anyway xD
…On Thu, Apr 12, 2018 at 12:17 PM, Drenn1 ***@***.***> wrote:
Also, so I can test this later, can you give an example of a homebrew that
this fixes?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#164 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcnhQWX2UAY3rBRP1q13aKW07HAHL3O8ks5tn4wpgaJpZM4TR2am>
.
|
|
To be fair, it's been a while since I compiled this branch. Maybe some of those changes were needed. (I more recently worked on the v0.5-hotfix branch.) |
|
Yeah, there are several issues with the pre-existing code... of course, my
added code caused even more, which is why I undid my changes.
…On Thu, Apr 12, 2018 at 1:32 PM, Drenn1 ***@***.***> wrote:
To be fair, it's been a while since I compiled this branch. Maybe some of
those changes were needed. (I more recently worked on the v0.5-hotfix
branch.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#164 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcnhQVcJvXIMtel_gg4Sk9yDMTMY9lNzks5tn53TgaJpZM4TR2am>
.
|
|
|
sorry *nix purists, Windows is what I use, so Windows is what the makefiles have to be for
|
Fixed the tab issue. |
|
@Drenn1 I fixed the tab issue (i think) |
Needs fixed as around half the time this is triggered, the emulator hangs, but it's a good start.
HOLY HELL WE DID IT
dude i'm so excited over the cpu_instrs test
|
yeah no, just reject this i'm just gonna make it a parallel project |
you'll be seeing more of these probably
just something i didn't catch when i reworked I/O earlier, lol
i'm tired
Yes, again.
|
Well, feel free to make another PR when this is ready... no reason to fork the codebase unless this has a large speed impact. |
I've added proper invalid-bank switching behavior. Should make some homebrew and bootlegs more stable.
(Don't mind my stupid commit names)