Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't switch to tab group with 0 tabs #1

Closed
RichardDavies opened this issue Nov 14, 2017 · 8 comments
Closed

Can't switch to tab group with 0 tabs #1

RichardDavies opened this issue Nov 14, 2017 · 8 comments
Labels

Comments

@RichardDavies
Copy link

If you close all of the tabs in a group and switch to another group, you're unable to return to the group with 0 tabs. You have to expand the group to view the group details and click the "Open new tab" link to create a blank tab in the group before it will let you switch back to that group.

@Drive4ik
Copy link
Owner

This is due to the fact that closing the last tab closes firefox.

@RichardDavies
Copy link
Author

...Not if you have any pinned tabs. Sorry I forgot to mention that I have several pinned tabs (which aren't considered part of any tab group) so when I close all of the tabs in the current group, the Firefox window doesn't close because the pinned tabs are still open.

@RichardDavies
Copy link
Author

Also, off topic, but I don't know how else to report it. The Simple Tab Groups extension seems to have mysteriously disappeared from addons.mozilla.org after I installed it just a few hours ago. https://addons.mozilla.org/en-US/firefox/addon/simple-tab-groups/ results in a Page Not Found error.

@Drive4ik
Copy link
Owner

Drive4ik commented Nov 15, 2017

...Not if you have any pinned tabs.

I'll think about how this can be implemented in the plugin.

The Simple Tab Groups extension seems to have mysteriously disappeared from addons.mozilla.org after I installed it just a few hours ago.

This was due to the fact that I used the javascript Vue library (https://vuejs.org/) to speed development. And it in turn uses eval(). According to Mozilla Corporation rules, you can not use eval() in plug-ins.

Extensions developed with WebExtension APIs have a Content Security Policy (CSP) applied to them by default. This restricts the sources from which they can load <script> and <object> resources, and disallows potentially unsafe practices such as the use of eval().

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Content_Security_Policy

At the moment I'm doing the rewriting of the plugin without using third-party libraries (except jQuery). And the plug-in will be available soon

@Drive4ik
Copy link
Owner

Addon is updated.
Please, update it

@RichardDavies
Copy link
Author

Perfect. Now I can switch to a group with 0 tabs. Thanks for the quick fix!

@Drive4ik
Copy link
Owner

@RichardDavies
Copy link
Author

it doesn't look like my review mentioned this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants