Droneshare login field validation and keyboard release #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count creation - it'd occasionally persist after login screen was dismissed.
… message are added to fields missing values, login can only proceed once all fields have been entered.
…characters, with 1 digit. Login allows abritary passwords, since existing accounts might not meet this requirement.
peterhinson
changed the title
| } | ||
| } | ||
|
|
||
| public abstract class TextValidator implements TextWatcher { |
There was a problem hiding this comment.
TextValidator should be declared as a static inner class since it doesn't use any references from the parent class.
|
@peterhinson your PR looks great! |
|
@peterhinson These are usually placed in the |
m4gr3d
added a commit
that referenced
this pull request
Mar 4, 2015
Droneshare login field validation and keyboard release
|
Good to know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic validation to username, password, and email when registering/logging into Droneshare.
The validation is pretty simple: usernames must be >1 characters. Emails must be .. well, emails. Login/signup is prevented unless the fields validate, and an error icon with an informative message is appended to the invalid field.
Passwords are little more tricky- Droneshare requires at least 7 characters and 1 digit. This hasn't been enforced via account creation using their API however, so DroidPlanner users have been able to create arbitrary passwords. I've added the character and digit restrictions to signup, but allow logging in users to use passwords of any length.
While it's nice to have instant feedback on what you're doing wrong within the app, this creates independent validation rules on the client and server. In the long run, it seems like the server should be responsible for validation.
I also added a method to hide the keyboard after login/signup. If the user hadn't hidden it at time of login, it would stay on screen after loading the Droneshare dashboard.
This is my first contribution to DroidPlanner/Tower (hoorah), figured something harmless would be a good start. Please let me know if I'm stepping on any of your contrib guidelines! :)