Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The application shall use only one serialization framework #11

Open
mpostol opened this issue Dec 3, 2019 · 4 comments
Open

The application shall use only one serialization framework #11

mpostol opened this issue Dec 3, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mpostol
Copy link
Collaborator

mpostol commented Dec 3, 2019

It is part of #7

CrossHMI.Shared.Configuration.BoilersConfigurationData uses JSON. You can add all the required details without marring serialization formats. What is the reason?

To get more visit the Reactive Networking (RxNetworking) Configuration

@mpostol mpostol added the enhancement New feature or request label Dec 3, 2019
@mpostol
Copy link
Collaborator Author

mpostol commented Dec 3, 2019

CrossHMI.Shared.BL.Consumer.ConfigurationFactory uses also DataContractSerializer.
Select a different overload of the ConfigurationDataFactoryIO.Load method. This overload is for special purposes if the available serialization methods cannot be used for some purpose, e.g. unit tests.

@Drutol
Copy link
Owner

Drutol commented Dec 5, 2019

Hmm, that's impossible to use the other overload though. In this environment FileInfo class does not apply, there's no file per say.

Drutol added a commit that referenced this issue Dec 5, 2019
@Drutol
Copy link
Owner

Drutol commented Dec 5, 2019

I've removed the ugly workaraound with JSON embedded into XML...
Now all configuration is serialized to JSON.

@mpostol
Copy link
Collaborator Author

mpostol commented Dec 9, 2019

If it is ready for review change assignment to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants