Joe/6.3 bugfix/error event serialization #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #1362 Thrown exceptions can't be serialized by System.Text.Json, because they contain pointers that it won't allow. This fix (suppressing serialization) is specific to the 6.3 release. In 7.0, we will remove the property entirely.
josephdecock
force-pushed
the
joe/6.3-bugfix/error-event-serialization
branch
from
b31eef2
to
523723e
Compare
brockallen
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #1363 into the 6.3 release.
The issue is that thrown exceptions can't be serialized by System.Text.Json, because they contain pointers that it won't allow.
This fix (suppressing serialization) is specific to the 6.3 release, to avoid a breaking change to the event type.
In 7.0, we will remove the property entirely.