[FeatureRequest]: M591 filament monitoring option for USB control

[jaysuk]

Is your feature request related to a problem? Please describe.

See this thread https://forum.duet3d.com/topic/31221/filament-monitoring-while-printing-via-usb?_=1685740576518

Describe the solution you propose.

See the above thread

Describe alternatives you've considered

Ex. A workaround exists but it is tedius, for example...

Provide any additional context or information.

Ex. Photos, mockups, etc.

[jaysuk]

and also see here https://forum.duet3d.com/topic/32626/rotating-magnet-filament-sensor-with-external-print/5

[jaysuk]

also, implementing host action commands from Marlin may give the best compatibility to existing server control software https://marlinfw.org/docs/configuration/configuration.html#host-action-commands

[chrishamm]

This isn't a high priority at the moment. It should be already possible to develop a work-around using daemon.g and something like this:

var hadFilamentError = false
while true
  G4 S1 ; check once per second
  if sensors.filamentMonitors[0].status != "ok"
    if !var.hadFilamentError
      M118 S"Filament error! Do something."
      set var.hadFilamentError = true
  else
    set var.hadFilamentError = false

Note that I have not tested this macro yet.

[T3P3]

@jay please can you have a look at this and see if its working for you now.

[dc42]

Issues to be resolved:

• The response to M591 D# by itself doesn't distinguish between enable modes 1 and 2 (now fixed)
• There was a use of = where == was intended, that GCC did not pick up (now fixed)
• Although the code that calls the filament monitor Check or Clear function takes account of the enable mode in both RRF and Duet3Expansion, the subsequent code in RRF still checks if we are really printing before raising an event. To account properly for the enable mode, RRF will need to keep track of the enable mode of remote filament monitors, or the enable mode will need to be included in the CAN message that passes filament monitor status back to the main board. We could possibly include the filament sensor enable mode in the 'extra' field of the reply to the configuration message.

[dc42]

Now fixed and tested.