Improve error message returned when user has no email templates

[johnbradley]

When this happens you receive this error response:

<h1> Server Error (500) </h1>

[dleehr]

This came up again today

Despite the error I get, not sure who to send this to, since I don’t know if it’s a script issue or server issue. The person I’m testing with doesn’t get an email, nor does his instance of Data Service get a copy of the project I’m trying to send.

Finally got everything working for uploading, but when I try delivering data to someone, I get this:

ddsclient deliver -p xxx --user xxxx
Delivering project.
Downloading a copy of 'xxx'.
Done: 100%
Uploading to 'xxx 2017-07-26 14:12'.
Done: 100%

Request to https://d4s2.gcb.duke.edu/api/v1/deliveries/x/send/ failed with 500:
<h1>Server Error (500)</h1>.

[dleehr]

Related to #106

[dleehr]

Seen again by @hlapp in #180

[hlapp]

This happens when which user has no email template? The sender or the recipient? I assume the sender, because that the recipient doesn't have a template will be normal?

So the assumption would be that normally this won't happen because an actual core will have a template set up?

[dleehr]

This happens when which user has no email template? The sender or the recipient? I assume the sender, because that the recipient doesn't have a template will be normal?

We've since updated D4S2 to use a set of default templates, so nobody should see this error when creating a delivery. But we have some cleanup to do on how to make sure those templates exist (#181).

I think the error you saw on monday (#180) was due to D4S2 looking up a template based on the recipient (and not the sender), and we'll get to the bottom of that too.

[dleehr]

@johnbradley Same fate as #180?

[johnbradley]

Fixed by #183