Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files without extensions will be created as a dir/file instead of file #47

Closed
pat-s opened this issue Jul 26, 2024 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@pat-s
Copy link

pat-s commented Jul 26, 2024

Hi!

First, thanks a lot for this package. It has made my interactions with S3 backends much easier compared to using {paws}.

I noticed the following niche issue when uploading a file without extension using s3_file_upload():

Assuming a remote path of $BUCKET/my/file, the resulting file will be created as $BUCKET/my/file/file - instead of $BUCKET/my/file.
When using paws.storage::s3()$put_object() directly, this is not the case (i.e. it works as intended) and $BUCKET/my/file gets created.

@DyfanJones DyfanJones added the bug Something isn't working label Jul 26, 2024
@DyfanJones
Copy link
Owner

Ah sorry about that. I am currently jumping between open source projects. Happy to receive PR's so if you are able to find the issue first please feel free to raise a PR. I am really grateful for any contributions :)

@pat-s
Copy link
Author

pat-s commented Jul 26, 2024

Ah no worries!
I can use {paws} in the meantime, as it is only one file that is affected by this.

Just wanted to let you (and others) know as it took me a while to get the idea that it could be a package problem and not a generic S3 one :)

@DyfanJones
Copy link
Owner

Managed to squeeze sometime in :D @pat-s can you give dev version ago

remotes::install_github("dyfanjones/s3fs", ref = "file_upload")

@pat-s
Copy link
Author

pat-s commented Jul 26, 2024

Works great, thanks!

@pat-s
Copy link
Author

pat-s commented Aug 28, 2024

Thanks again, would appreciate a CRAN release if you have time (and maybe more changes than only this one) :)

@pat-s pat-s closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants