New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't fail to parse urls from warning messages that include repeated warnings. #12267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mjkkirschner do you think that other parts of dynamo could misbehave because of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pinzart90 - I'm not sure, I actually think that the delta execution behavior is correct, and the first execution only containing a single expressionID is incorrect - it just happened that this masks the documentation issue when testing simple interactions. |
Purpose
This PR fixes two issues with the documentation browser:
DereferencingANonePointer exception was mis spelled.
Sometimes during delta execution warnings will have different expressionIDs assigned for certain nodes that are composed of multiple expressions - like a multi-output node.
The end result is that the warning text is composed of multiple warnings like:
Dereferencing null pointer - DereferencingNonePointer.html/n Dereferencing null pointer - DereferencingNonePointer.html/n Dereferencing null pointer - DereferencingNonePointer.html
The code that parses url's expected that all warning strings would only be composed of a single single url - instead we make the splitting a bit smarter, by also using the same delimiter that is used to join the warnings.
This code returns the first url found.
TODO
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Fixed a bug where documentation for errors could not be found, or reported illegal characters in the documentation browser.