DYN-6901 Pm - publish process improvements #15314
Conversation
- plotting out the publishing process with series of tests
- previously dynamo would add dyf and dll files regardless of the capitalization of the extesion. However - however, when copying the files this was not respected - now also copies the files awith upper capitalization
- fixed caps extension issue in preview and remove
- confirm that the original custom definition files will be deleted during the build process - fixed a few more extension capitalizations
UI Smoke TestsTest: success. 3 passed, 0 failed. |
|
@dnenov Do we have a task for this? |
- rework on the way the content structure is recreated (files and folders relationships) - additional test coverage to assert edge case scenarios
Hi @reddyashish - it is part of the PackageManager update, no jira task yet, and it's still WIP |
Hi @dnenov is it not logged as part of release epic https://jira.autodesk.com/browse/DYN-5270? |
dnenov
changed the title
dnenov
changed the title
QilongTang
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6901
| //now add the second assembly version file | ||
| vm.AddFile(secondAssembly); | ||
|
|
||
| //TODO: assert - do we expect to see 1 or 2 here? |
There was a problem hiding this comment.
Nice, this is a good one to revisit later.
| { | ||
| var vm = new PublishPackageViewModel(ViewModel); | ||
| var items = new Dictionary<string, PackageItemRootViewModel>(); | ||
| var files = new[] { new FileInfo(@"C:\pkg\file1.dyn"), new FileInfo(@"C:\pkg\file2.DYN") }; |
There was a problem hiding this comment.
Nice case with capitalized file format
|
@dnenov Can you take a look at the reported regression DynamoCoreWpfTests.PublishPackageViewModelTests.EnsureMultipleVersionsOfAssembly_CannotBeLoaded to see if it needs to be updated? |
Yes, I think it was the test files being ignored. I added them back in, it should pass now I hope. |
Purpose
This is the first PR of a series of changes to the
publish a package using retain folder structurewhich aims to fix and updates a lot of the issues the process has had since its launch. I tried to keep the separate PRs relevant to a single change and as small as possible.Changes in this PR
BindParentToChildandGetCommonPathsmethods. Historically, after loading files during the publish package process, Dynamo did not capture the relationships between files and folders, as the only option was to cluster everything into the 4 main folders -bin,doc,dyf,extra.After introducing the concept of retaining the existing folder structure, this information became important. The 2 methods above do the job by post-processing all the 'raw' file paths each time after a new file or folder has been added to the collection via the UI.
x.EndsWith(".dyf")->x.ToLower().EndsWith(".dyf"))Limitations to the current process
Dynamo does not allow loading of multiple .dll versions- created a test to highlight this limitation: EnsureMultipleVersionsOfAssembly_CannotBeLoaded()Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@zeusongit
@reddyashish
FYIs
@Amoursol