Pm - files and folders counter - UI improvements #15359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- plotting out the publishing process with series of tests
- previously dynamo would add dyf and dll files regardless of the capitalization of the extesion. However - however, when copying the files this was not respected - now also copies the files awith upper capitalization
- fixed caps extension issue in preview and remove
- confirm that the original custom definition files will be deleted during the build process - fixed a few more extension capitalizations
- rework on the way the content structure is recreated (files and folders relationships) - additional test coverage to assert edge case scenarios
- added visual counter to display the progress when adding files to the package manager
- added text localization for the counter
…ructure-updates-ui
…tructure-updates-ui
dnenov
changed the title
|
@dnenov looking good! Please do engage with @Jingyi-Wen on the UX of where and how that message manifests. |
reddyashish
reviewed
Jul 11, 2024
| /// </summary> | ||
| /// <param name="items">A dictionary of the content items</param> | ||
| /// <returns></returns> | ||
| internal List<PackageItemRootViewModel> BindParentToChild(Dictionary<string, PackageItemRootViewModel> items) |
There was a problem hiding this comment.
The same file changes are also present in #15360
…ructure-updates-ui
reddyashish
reviewed
Jul 11, 2024
src/DynamoCoreWpf/Views/PackageManager/Pages/PublishPackagePreviewPage.xaml.cs
Show resolved
Hide resolved
UI Smoke TestsTest: success. 11 passed, 0 failed. |
- jingyi discussion
reddyashish
approved these changes
Jul 16, 2024
QilongTang
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a UI-related suggestion. When publishing a package, especially one containing a large number of files and folders, it is important to keep track of the actual number of files created as a result. This PR adds a visual cue to that number (not discussed with anyone on the team yet).
This PR is based on #15314
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@zeusongit
FYIs
@Amoursol